vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator
context to logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#discussion_r219549936
##########
File path:
common/src/main/java/org/apache/drill/common/exceptions/UserExceptionContext.java
##########
@@ -141,7 +141,7 @@ String generateContextMessage(boolean
includeErrorIdAndIdentity, boolean include
}
if (includeSeeLogsMessage) {
- sb.append("Please, refer to logs for more information.\n");
+ sb.append("\nPlease, refer to logs for more information.\n");
Review comment:
Looks like on Windows some editors like Notepad don't consider `\n` as line
separator.
For instance, `Intelij Idea` terminal on Windows shows:
```
0: jdbc:drill:zk=local> select * from cp.`employee.json` where full_name = 5;
Error: SYSTEM ERROR: NumberFormatException: Sheri Nowmer
Fragment 0:0
Please, refer to logs for more information.
[Error Id: bdf70e30-4b36-48cf-8d97-39b2d31dbece on 10.2.14.127:31010]
(state=,code=0)
```
but `sqlline.log` in NotePad shows:
```
2018-09-21 18:49:11,972 [245aed07-be42-1f73-4905-f1bbc400f50d:frag:0:0]
ERROR o.a.d.e.w.fragment.FragmentExecutor - SYSTEM ERROR:
NumberFormatException: Sheri NowmerFragment 0:0Please, refer to logs for more
information.[Error Id: bdf70e30-4b36-48cf-8d97-39b2d31dbece on
10.2.14.127:31010]
org.apache.drill.common.exceptions.UserException: SYSTEM ERROR:
NumberFormatException: Sheri NowmerFragment 0:0Please, refer to logs for more
information. [Error Id: bdf70e30-4b36-48cf-8d97-39b2d31dbece on
10.2.14.127:31010]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
