vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220549291
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java ########## @@ -47,7 +47,8 @@ protected final boolean unionTypeEnabled; protected BatchState state; - // In case of Exception will be IterOutcome.STOP + // Used for state dump + protected boolean failed; Review comment: I still think that it is better to use existing BatchState or IterOutcome or even maybe exceptionState in `IteratorValidatorBatchIterator`. Why do we need two states for batch? In what cases they can be different? Looks like it is possible to set IterOutcome to STOP in case of any exception and then batches will be dumped. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
