arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r224006820
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/registry/FunctionRegistryHolderTest.java
##########
@@ -155,6 +162,47 @@ public void testGetAllJarNames() {
compareTwoLists(expectedResult, registryHolder.getAllJarNames());
}
+ @Test
+ public void testGetAllJarsWithFunctionHolders() {
+ Map<String, List<FunctionHolder>> fnHoldersInRegistry =
registryHolder.getAllJarsWithFunctionHolders();
+ //Iterate and confirm lists are same
+ for (String jarName : Lists.newArrayList(newJars.keySet())) {
Review comment:
No need to wrap into ArrayList here and a couple more times below in the
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
