arina-ielchiieva commented on a change in pull request #1483: DRILL-3988:
Expose Drill built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r224006180
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/registry/FunctionRegistryHolderTest.java
##########
@@ -202,26 +250,38 @@ public void testGetAllFunctionsWithSignatures() {
public void testGetHoldersByFunctionNameWithVersion() {
List<DrillFuncHolder> expectedResult = newJars.values().stream()
.flatMap(Collection::stream)
- .filter(f -> "lower".equals(f.getName()))
+ .filter(f -> LOWER_FUNC_NAME.equals(f.getName()))
.map(FunctionHolder::getHolder)
.collect(Collectors.toList());
assertFalse(expectedResult.isEmpty());
AtomicInteger version = new AtomicInteger();
- compareTwoLists(expectedResult,
registryHolder.getHoldersByFunctionName("lower", version));
+ compareTwoLists(expectedResult,
registryHolder.getHoldersByFunctionName(LOWER_FUNC_NAME, version));
assertEquals("Version number should match", version.get(),
registryHolder.getVersion());
}
@Test
public void testGetHoldersByFunctionName() {
- List<DrillFuncHolder> expectedResult = newJars.values().stream()
- .flatMap(Collection::stream)
- .filter(f -> "lower".equals(f.getName()))
- .map(FunctionHolder::getHolder)
- .collect(Collectors.toList());
+ List<DrillFuncHolder> expectedUniqueResult = Lists.newArrayList();
Review comment:
Please use `new ArrayList<>` here and below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
