kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill 
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224942418
 
 

 ##########
 File path: exec/java-exec/src/main/resources/ace.mode-sql.template.js
 ##########
 @@ -0,0 +1,121 @@
+/**
 
 Review comment:
   The reason I have the template here is for easy access to the file within 
the classpath. I don't believe the `rest/static/js` folder is loaded into the 
classpath (which makes sense, because it serves REST API requests). If I move 
the template here, it is visible to any browser accessing 
`http://drillhost/static/js/options.describe.template.js` 
   
   I can remove `mode-sql.js` from the static resource, since we are doing a 
dynamic generation now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to