kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224942492
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
##########
@@ -456,21 +471,20 @@ public void close() throws Exception {
FileUtils.deleteDirectory(getTmpJavaScriptDir());
}
- private static final String FILE_CONTENT_FOOTER = "};";
-
//Generate Options Description JavaScript
private void generateOptionsDescriptionJSFile() throws IOException {
//Obtain list of Options & their descriptions
OptionManager optionManager =
this.drillbit.getContext().getOptionManager();
OptionList publicOptions = optionManager.getPublicOptionList();
- List<OptionValue> options = Lists.newArrayList(publicOptions);
+ List<OptionValue> options = new ArrayList<>(publicOptions);
Collections.sort(options);
int numLeftToWrite = options.size();
//Template source Javascript file
InputStream optionsDescripTemplateStream =
Resource.newClassPathResource(OPTIONS_DESCRIBE_TEMPLATE_JS).getInputStream();
//Generated file
File optionsDescriptionFile = new File(getTmpJavaScriptDir(),
OPTIONS_DESCRIBE_JS);
+ final String FILE_CONTENT_FOOTER = "};";
Review comment:
Ok. I was following the convention for a constant string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
