vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225504704
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ########## @@ -87,6 +95,8 @@ private LinkedList<SizedJBlock>[] blocks; private LinkedList<SizedJBlock>[] oldBlocks; + private JVar innerClassField; + /** * Assumed that field has 3 indexes within the constant pull: index of the CONSTANT_Fieldref_info + Review comment: Please note that with introducing new methods in the class, this formula should be revised to take them into account. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services