vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen 
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r223320666
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
 ##########
 @@ -536,6 +543,19 @@ public JVar declareClassField(String prefix, JType t, 
JExpression init) {
     return clazz.field(JMod.NONE, t, prefix + index++, init);
   }
 
+  public JMethod declareSetterMethod(JVar var, Function<DrillBuf, ? extends 
ValueHolder> function) {
 
 Review comment:
   Please add Javadoc here also.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to