vvysotskyi commented on a change in pull request #1446: DRILL-6349: Drill JDBC
driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
URL: https://github.com/apache/drill/pull/1446#discussion_r226629193
##########
File path: exec/java-exec/pom.xml
##########
@@ -71,10 +71,15 @@
<!-- </dependency> -->
<dependency>
<groupId>org.ow2.asm</groupId>
- <artifactId>asm-debug-all</artifactId>
- <version>5.0.3</version>
+ <artifactId>asm-commons</artifactId>
+ <version>6.2.1</version>
<!-- <scope>test</scope> -->
</dependency>
+ <dependency>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>asm-util</artifactId>
Review comment:
New asm version supports jdk 10, but there `asm-debug-all` jar was removed
(see
https://gitlab.ow2.org/asm/asm/commit/4c449bea1e3fb980238c61d60103fe1be76e77e5),
so new dependencies, where classes used by Drill are available were introduced.
If I understand correctly, `jaxb-api` and `activation` dependencies were
added due to http://openjdk.java.net/jeps/320.
@oleg-zinovev, Is it make sence to move these two dependencies to the root
pom?
Also, please remove commented out lines introduced in previous commits and
move version for `asm` dependencies to the property in the root pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
