vvysotskyi commented on a change in pull request #1446: DRILL-6349: Drill JDBC
driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
URL: https://github.com/apache/drill/pull/1446#discussion_r229278004
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/JDKClassCompiler.java
##########
@@ -55,7 +55,7 @@ private JDKClassCompiler(JavaCompiler compiler, ClassLoader
classLoader, boolean
this.compiler = compiler;
this.listener = new DrillDiagnosticListener();
this.fileManager = new
DrillJavaFileManager(compiler.getStandardFileManager(listener, null,
Charsets.UTF_8), classLoader);
- this.compilerOptions = Lists.newArrayList(this.debug ?
"-g:source,lines,vars" : "-g:none");
+ this.compilerOptions = Lists.newArrayList("-source", "1.8", "-target",
"1.8", this.debug ? "-g:source,lines,vars" : "-g:none");
Review comment:
I assume this change should be reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
