kkhatua commented on a change in pull request #1507: DRILL-6715: Update
descriptions for System Options table
URL: https://github.com/apache/drill/pull/1507#discussion_r227804458
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
##########
@@ -480,6 +480,9 @@ private void generateOptionsDescriptionJSFile() throws
IOException {
OptionManager optionManager =
this.drillbit.getContext().getOptionManager();
OptionList publicOptions = optionManager.getPublicOptionList();
List<OptionValue> options = new ArrayList<>(publicOptions);
+ //Add internal options
Review comment:
Oh. The webpages are different.
The public options are accessible via `http://<drillHost>/options`
The internal options are accessible via
`http://<drillHost>/internal_options` , but there is no visible link. Users
(developers/admin) need to be aware of it. So, it is not easily accessible.
Both webpages' javascripts refer to the same file as a source for the
descriptions. But the rendering is done based on what options are shown on
which page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
