kkhatua commented on a change in pull request #1507: DRILL-6715: Update 
descriptions for System Options table
URL: https://github.com/apache/drill/pull/1507#discussion_r227883643
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
 ##########
 @@ -480,6 +480,9 @@ private void generateOptionsDescriptionJSFile() throws 
IOException {
     OptionManager optionManager = 
this.drillbit.getContext().getOptionManager();
     OptionList publicOptions = optionManager.getPublicOptionList();
     List<OptionValue> options = new ArrayList<>(publicOptions);
+    //Add internal options
 
 Review comment:
   I guess I really dug into the Freemarker pages to have discovered this. 😄 
   Not sure where (if at all) this was documented. But since the page exists, 
it makes sense to have the descriptions available as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to