lushuifeng commented on issue #1524: DRILL-6830: Remove Hook.REL_BUILDER_SIMPLIFY handler after use URL: https://github.com/apache/drill/pull/1524#issuecomment-436478375 @vvysotskyi There are some type mismatch errors in the tests since RelBuilder.simplify is not always false so simplifier.simplifyPreservingType will be invoked in some tests. These errors are reproducible by running one test at a time, say running `TestCaseNullableTypes#testCaseNullableTypesVarchar` alone on master, the tests are passed if running all tests in TestCaseNullableTypes at once. Should I fixed these errors in this PR or create another ticket? I have to say that I am not quite familiar with Calcite.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
