lushuifeng commented on issue #1524: DRILL-6830: Remove 
Hook.REL_BUILDER_SIMPLIFY handler after use
URL: https://github.com/apache/drill/pull/1524#issuecomment-436552784
 
 
   I think the tests are failed because the misused of Hook, running 
TestCaseNullableTypes#testCaseNullableTypesVarchar alone on master gets the 
error either.
   we can put `static {
       Hook.REL_BUILDER_SIMPLIFY.add(Hook.propertyJ(false));
     }` somewhere to keep the old way instead of adding a new one to the Hook, 
but the final solution is to fix the errors in the tests.
   I think it would still get the errors when close the hook after finishing 
planning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to