sohami commented on a change in pull request #1561: DRILL-6751: Upgrade Apache
parent POM to version 21
URL: https://github.com/apache/drill/pull/1561#discussion_r239172730
##########
File path: pom.xml
##########
@@ -686,10 +685,14 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.0</version>
+ <configuration>
+ <source>${maven.compiler.source}</source>
+ <target>${maven.compiler.target}</target>
+ </configuration>
Review comment:
this is not required as we already have these properties defined
[here](https://github.com/apache/drill/pull/1561/commits/f6c2d3bd49734af0daee6e94f43eaeff3d9db238#diff-600376dffeb79835ede4a0b285078036R41).
Please see
[this](https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html)
for ref.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
