sohami commented on a change in pull request #1561: DRILL-6751: Upgrade Apache
parent POM to version 21
URL: https://github.com/apache/drill/pull/1561#discussion_r239190524
##########
File path: distribution/pom.xml
##########
@@ -156,26 +156,40 @@
<build>
<plugins>
- <plugin>
+ <plugin>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
- <execution>
- <id>distro-assembly</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
- <configuration>
- <descriptors>
- <descriptor>src/assemble/bin.xml</descriptor>
- </descriptors>
- <appendAssemblyId>false</appendAssemblyId>
- <finalName>apache-drill-${project.version}</finalName>
- <tarLongFileMode>gnu</tarLongFileMode>
- </configuration>
- </execution>
+ <execution>
+ <id>distro-assembly</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/assemble/bin-assembly.xml</descriptor>
+ </descriptors>
+ <appendAssemblyId>false</appendAssemblyId>
+ <finalName>apache-drill-${project.version}</finalName>
+ </configuration>
+ </execution>
+ <execution>
+ <id>distro-assembly-not-attached</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <attach>false</attach>
Review comment:
what is the role of this parameter ? Not very clear from documentation. Is
it like whether to include assembly file in project or not ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
