vdiravka commented on a change in pull request #1586: DRILL-6929: Exclude
maprfs jar for default profile
URL: https://github.com/apache/drill/pull/1586#discussion_r244180217
##########
File path:
contrib/storage-hive/core/scrMapr/main/java/org/apache/drill/exec/planner/sql/logical/ConvertHiveMapRDBJsonScanToDrillMapRDBJsonScan.java
##########
@@ -110,15 +100,15 @@ Hive does not always give correct costing (i.e. for
external tables Hive does no
To ensure Drill MapR-DB Json scan will be chosen, reduce Hive scan
importance to 0.
*/
call.getPlanner().setImportance(hiveScanRel, 0.0);
- } catch (final Exception e) {
+ } catch (RuntimeException e) {
Review comment:
I think earlier some method or constructor required re-throwing Exception in
the `createNativeScanRel()` method.
So there is no need to swallow `RuntimeExceptions` here from now.
Native Reader will not be used in that case. So it is better to disable it
explicitly and to be aware of `RuntimeExceptions` in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
