vdiravka commented on a change in pull request #1586: DRILL-6929: Exclude
maprfs jar for default profile
URL: https://github.com/apache/drill/pull/1586#discussion_r244222393
##########
File path:
contrib/storage-hive/core/scrMapr/main/java/org/apache/drill/exec/planner/sql/logical/ConvertHiveMapRDBJsonScanToDrillMapRDBJsonScan.java
##########
@@ -110,15 +100,15 @@ Hive does not always give correct costing (i.e. for
external tables Hive does no
To ensure Drill MapR-DB Json scan will be chosen, reduce Hive scan
importance to 0.
*/
call.getPlanner().setImportance(hiveScanRel, 0.0);
- } catch (final Exception e) {
+ } catch (RuntimeException e) {
Review comment:
Looks like for future we might consider to add trowing `IOException` to all
`getFormatPlugin()` methods. And `Throwables.throwIfInstanceOf(e.getCause(),
IOException.class);` for `MapRDBFormatPlugin.getFormatPlugin()`. But for now
only `MapRDBFormatPlugin` requires it.
Could you write a short TODO about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
