arina-ielchiieva commented on a change in pull request #1599: DRILL-6903:
SchemaBuilder code improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r246035970
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/AbstractColumnMetadata.java
##########
@@ -87,7 +86,8 @@ public AbstractColumnMetadata(AbstractColumnMetadata from) {
expectedElementCount = from.expectedElementCount;
}
- protected void bind(TupleSchema parentTuple) { }
+ @Override
+ public void bind(TupleMetadata parentTuple) { }
Review comment:
Was made public and moved to the interface to allow using `ColumnMetadata`
interface rather than casting to `AbstractColumnMetadata`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
