arina-ielchiieva commented on a change in pull request #1599: DRILL-6903:
SchemaBuilder code improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r246039676
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/TupleSchema.java
##########
@@ -145,6 +145,11 @@ public boolean isEquivalent(TupleMetadata other) {
return cols;
}
+ @Override
+ public List<ColumnMetadata> toMetadataList() {
+ return new ArrayList<>(nameSpace.entries());
+ }
Review comment:
Will be used to iterate over columns metadata and convert them into
List<String> which will be used for schema ser / de. I can add Javadocs with
use case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
