amansinha100 commented on a change in pull request #729: Drill 1328: Support
table statistics for Parquet
URL: https://github.com/apache/drill/pull/729#discussion_r250441772
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillScanRelBase.java
##########
@@ -26,23 +26,28 @@
import org.apache.drill.common.exceptions.DrillRuntimeException;
import org.apache.calcite.rel.core.TableScan;
import org.apache.calcite.plan.RelOptCluster;
+import org.apache.calcite.plan.RelOptCost;
+import org.apache.calcite.plan.RelOptPlanner;
import org.apache.calcite.plan.RelOptTable;
import org.apache.calcite.plan.RelTraitSet;
import org.apache.drill.exec.util.Utilities;
+import org.apache.calcite.rel.metadata.RelMetadataQuery;
/**
* Base class for logical/physical scan rel implemented in Drill.
*/
public abstract class DrillScanRelBase extends TableScan implements
DrillRelNode {
protected GroupScan groupScan;
protected final DrillTable drillTable;
+ protected List<SchemaPath> columns;
Review comment:
Not sure why we need to add columns field here since it is redundant...the
GroupScan (associated with this DrillScanRel) already keeps track of the
columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
