amansinha100 commented on a change in pull request #729: Drill 1328: Support
table statistics for Parquet
URL: https://github.com/apache/drill/pull/729#discussion_r256200721
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AnalyzePrule.java
##########
@@ -41,30 +44,41 @@
private static final List<String> PHASE_1_FUNCTIONS = ImmutableList.of(
Statistic.ROWCOUNT, // total number of entries in table fragment
Statistic.NNROWCOUNT, // total number of non-null entries in table
fragment
- Statistic.SUM_WIDTH, // total column width across all entries in
table fragment
- Statistic.HLL // total distinct values in table fragment
+ Statistic.SUM_WIDTH, // total column width across all entries in table
fragment
+ Statistic.CNT_DUPS, // total count of non-singletons in table fragment
+ Statistic.HLL // total distinct values in table fragment
);
// Mapping between output functions (from StatsMergeBatch) and
// input functions (from StatsAggBatch)
- private static final Map<String, String> PHASE_2_FUNCTIONS = ImmutableMap.of(
+ private static Map<String, String> PHASE_2_FUNCTIONS = new HashMap<>();
+ /*ImmutableMap.of(
Review comment:
Remove commented out block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
