amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin 
is changing the join ordering for some tpcds que…
URL: https://github.com/apache/drill/pull/1620#discussion_r250847043
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
 ##########
 @@ -277,6 +277,10 @@ protected DrillRel convertToRawDrel(final RelNode 
relNode) throws SqlUnsupported
         }
       }
 
+      if (context.getPlannerSettings().isSemiJoinEnabled() &&
 
 Review comment:
   Pls add a brief explanation as comments for why the semi join conversion is 
done at this stage of the planning process after the normal join ordering is 
done. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to