amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin
is changing the join ordering for some tpcds que…
URL: https://github.com/apache/drill/pull/1620#discussion_r251210970
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
##########
@@ -277,6 +277,12 @@ protected DrillRel convertToRawDrel(final RelNode
relNode) throws SqlUnsupported
}
}
+ /*Ideally this conversion can be handled during logical planning phase
itself but currently the join ordering algorithm in calcite
+ is not considering the semi-joins. This can lead to sub optimal plans.
Hence converting the joins to semi-joins post join planning.*/
Review comment:
For future reference, pls add the CALCITE-xxx JIRA number for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
