amansinha100 commented on a change in pull request #729: Drill 1328: Support
table statistics for Parquet
URL: https://github.com/apache/drill/pull/729#discussion_r256195252
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java
##########
@@ -236,6 +236,7 @@ public void setup() {
work = new ObjectHolder();
hllAccuracy.value = (int)
options.getLong(org.apache.drill.exec.ExecConstants.HLL_ACCURACY);
work.obj = new
com.clearspring.analytics.stream.cardinality.HyperLogLog(hllAccuracy.value);
+ work.obj = new
com.clearspring.analytics.stream.membership.BloomFilter(1000000, 0.10);
Review comment:
Shouldn't these constants in the constructor be configurable ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
