ihuzenko commented on a change in pull request #1608: DRILL-6960: AutoLimit the
size of ResultSet for a WebUI (or REST) client
URL: https://github.com/apache/drill/pull/1608#discussion_r256290038
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
##########
@@ -144,7 +145,8 @@ public Foreman(final WorkerBee bee, final DrillbitContext
drillbitContext,
this.closeFuture = initiatingClient.getChannelClosureFuture();
closeFuture.addListener(closeListener);
- this.queryContext = new QueryContext(connection.getSession(),
drillbitContext, queryId);
+ this.queryContext = new QueryContext(connection.getSession(),
drillbitContext, queryId,
+ connection instanceof WebUserConnection ? ((WebUserConnection)
connection).getAutoLimitRowCount() : null);
Review comment:
please extract this line to local variable, it will simplify debugging in
future and the constructor invocation will look more compact
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
