ihuzenko commented on a change in pull request #1608: DRILL-6960: AutoLimit the
size of ResultSet for a WebUI (or REST) client
URL: https://github.com/apache/drill/pull/1608#discussion_r257202711
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java
##########
@@ -177,6 +181,16 @@ public String getRowsPerPageValues() {
public String getQueryState() {
return queryState;
}
+
+ //Used by results.ftl to indicate autoLimited resultset
+ public boolean resultsAutoLimited() {
Review comment:
It's a good practice when name of method that returns ```boolean``` starts
from ```is``` or ```has``` prefix. For example check the rule
https://rules.sonarsource.com/java/tag/convention/RSPEC-2047.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
