vdiravka commented on a change in pull request #1641: DRILL-4858:
REPEATED_COUNT on an array of maps and an array of arrays is not implemented
URL: https://github.com/apache/drill/pull/1641#discussion_r256932985
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SimpleRepeatedFunctions.java
##########
@@ -77,8 +79,6 @@ public void eval() {
}
}
- /*
- // TODO - need to confirm that these work SMP: They do not
Review comment:
What about TODO?
> // TODO - replace with a freemarker template and fill out the rest of the
types
> // focused on getting functions defined for JSON types as this is the
primary format
> // users are extracting repeated data out of currently
May it be used for other datatypes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
