vdiravka commented on a change in pull request #1641: DRILL-4858:
REPEATED_COUNT on an array of maps and an array of arrays is not implemented
URL: https://github.com/apache/drill/pull/1641#discussion_r258588301
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SimpleRepeatedFunctions.java
##########
@@ -77,8 +79,6 @@ public void eval() {
}
}
- /*
- // TODO - need to confirm that these work SMP: They do not
Review comment:
> Not sure what you mean. Do you mean to create a template instead as the
TODO suggests?
Yes. But I am not sure that it will save much more space for current
`repeated_count` functions, since there are different implementations of
`eval()` method. But if some additional data types can be used with this
function, then it makes sense to add them and to consider rewriting this calss
with FreeMarker template.
So can other data types be used with `repeated_count` function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
