sohami commented on a change in pull request #1644: DRILL-7036: Improve UI for
alert and error messages
URL: https://github.com/apache/drill/pull/1644#discussion_r258633452
##########
File path: exec/java-exec/src/main/resources/rest/profile/list.ftl
##########
@@ -154,15 +154,19 @@
<strong>No running queries.</strong>
</div>
</#if>
+
+ <#include "*/alertModals.ftl">
+
<table width="100%">
<script type="text/javascript" language="javascript">
//Validate that the fetch number is valid
function checkMaxFetch() {
var maxFetch = document.forms["profileFetch"]["max"].value;
console.log("maxFetch: " + maxFetch);
if (isNaN(maxFetch) || (maxFetch < 1) || (maxFetch > 100000) ) {
- alert("Invalid Entry: " + maxFetch + "\n" +
- "Please enter a valid number of profiles to fetch (1 to 100000)
");
+ populateAndShowAlert('invalidProfileFetchSize',maxFetch);
+ //alert("Invalid Entry: " + maxFetch + "\n" +
Review comment:
remove commented out alert statements from here and other files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
