sohami commented on a change in pull request #1644: DRILL-7036: Improve UI for
alert and error messages
URL: https://github.com/apache/drill/pull/1644#discussion_r258803258
##########
File path: exec/java-exec/src/main/resources/rest/alertModals.ftl
##########
@@ -47,26 +47,21 @@
<script>
//Populate the alert modal with the right message params and show
function populateAndShowAlert(errorMsg, inputValues) {
- //console.log("placeHolder -> "+
JSON.stringify(errorMap[errorMsg].placeHolder));
- //console.log("inputValues -> "+ JSON.stringify(inputValues));
- modalHeader.innerHTML=errorMap[errorMsg].msgHeader;
- modalBody.innerHTML=errorMap[errorMsg].msgBody;
- let substNames=[];
- let substValues=[];
+ if (! errorMsg in errorMap) {
Review comment:
I think this needs to be changed to `if (!(errorMsg in errorMap))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
