paul-rogers commented on a change in pull request #1652: DRILL-7046: Support
for loading and parsing new RM config file
URL: https://github.com/apache/drill/pull/1652#discussion_r259596370
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java
##########
@@ -197,7 +197,8 @@ protected MessageLite getResponseDefaultInstance(int
rpcType) throws RpcExceptio
}
/**
- * {@link AbstractRemoteConnection} implementation for user connection. Also
implements {@link UserClientConnection}.
+ * {@link org.apache.drill.exec.rpc.AbstractRemoteConnection} implementation
for user connection.
Review comment:
Nit: The super class/interface is clear from the generated Javadoc; that
need not be explained here. What is helpful is that which cannot be extracted
from the code: what is the purpose of this class? What the heck is a "Bit to
user connection"? Is this where the Drillbit connects to a neural implant in
the user's brain? The Drillbit connects back to the user's client? Something
else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
