paul-rogers commented on a change in pull request #1652: DRILL-7046: Support for loading and parsing new RM config file URL: https://github.com/apache/drill/pull/1652#discussion_r259595925
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/resourcemgr/QueryQueueConfigImpl.java ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.resourcemgr; + +import com.typesafe.config.Config; +import org.apache.drill.exec.resourcemgr.exception.RMConfigException; + +import java.util.UUID; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +import static org.apache.drill.exec.resourcemgr.RMCommonDefaults.MAX_ADMISSIBLE_DEFAULT; +import static org.apache.drill.exec.resourcemgr.RMCommonDefaults.MAX_WAITING_DEFAULT; + +/** + * Parses and initialize QueueConfiguration for a {@link ResourcePool}. It also generates a unique UUID for each queue + * which will be later used by Drillbit to store in Zookeeper along with + * {@link org.apache.drill.exec.proto.beans.DrillbitEndpoint}. This UUID is used in the leader election mechanism in + * which Drillbit participates for each of the configured rm queue. + */ +public class QueryQueueConfigImpl implements QueryQueueConfig { + + private String queueUUID; + + private String queueName; + + private int maxAdmissibleQuery; + + private int maxWaitingQuery; + + private int maxWaitingTimeout; + + private boolean waitForPreferredNodes; + + private NodeResources queueResourceShare; + + private NodeResources queryPerNodeResourceShare; + + // Optional queue configurations + private static final String MAX_ADMISSIBLE_KEY = "max_admissible"; + + private static final String MAX_WAITING_KEY = "max_waiting"; + + private static final String MAX_WAIT_TIMEOUT_KEY = "max_wait_timeout"; + + private static final String WAIT_FOR_PREFERRED_NODES_KEY = "wait_for_preferred_nodes"; + + private static final String MAX_QUERY_MEMORY_PER_NODE_FORMAT = "([0-9]+)\\s*([kKmMgG]?)\\s*$"; + + // Required queue configurations in MAX_QUERY_MEMORY_PER_NODE_FORMAT pattern + private static final String MAX_QUERY_MEMORY_PER_NODE_KEY = "max_query_memory_per_node"; + + public QueryQueueConfigImpl(Config queueConfig, String poolName, + NodeResources queueNodeResource) throws RMConfigException { + this.queueUUID = UUID.randomUUID().toString(); + this.queueName = poolName; + parseQueueConfig(queueConfig, queueNodeResource); + } + + /** + * Assigns either supplied or default values for the optional queue configuration. For required configuration uses + * the supplied value in queueConfig object or throws proper exception if not present + * @param queueConfig - Config object for ResourcePool queue + * @param nodeShare - Share of resources on a node for this queue + * @throws RMConfigException - In case of error + */ + private void parseQueueConfig(Config queueConfig, NodeResources nodeShare) throws RMConfigException { Review comment: Factory method? Seem's we'd want some queue aspects to be immutable. They could be set via code (tests) or config file (production). But, once set, some attributes should be immutable (id, say). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
