vdiravka commented on a change in pull request #1651: DRILL-7042: Fix deb and 
rpm package issues
URL: https://github.com/apache/drill/pull/1651#discussion_r260215897
 
 

 ##########
 File path: distribution/pom.xml
 ##########
 @@ -379,34 +379,74 @@
               <name>drill</name>
 
 Review comment:
   Currently the name of rpm is `drill-1.0-SNAPSHOT.noarch.rpm`
   1. 
   ```suggestion
                 <name>apache-drill</name>
   ```
   2. Edit an above string:
   from `<version>1.0</version>` -> `<version>1.16.0-SNAPSHOT</version>`
   
   3. `<copyright>` tag isn't supported anymore for this plugin. Please use 
`<license>` instead of it. I think to put one line link 
`http://www.apache.org/licenses/LICENSE-2.0` as content instead of `2013 ASF` 
will be fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to