vdiravka commented on a change in pull request #1651: DRILL-7042: Fix deb and
rpm package issues
URL: https://github.com/apache/drill/pull/1651#discussion_r261652888
##########
File path: distribution/pom.xml
##########
@@ -371,42 +369,81 @@
</execution>
</executions>
<configuration>
- <copyright>2013 ASF</copyright>
+ <license>http://www.apache.org/licenses/LICENSE-2.0</license>
Review comment:
But it isn't done.
`<license>http://www.apache.org/licenses/LICENSE-2.0</license>` -> `
<license>${project.organization} ${project.licenses}</license>` as I
suggested in the first comment.
And `conffiles` and `control` files are not deleted. They still present in
your branch. This is the reason why TravisCI build is failed under your branch:
https://travis-ci.org/apache/drill/builds/500336628?utm_source=github_status&utm_medium=notification
the checks for `maven-license-plugin` is removed, but files are not deleted.
Please fix above two issues and then PR can be merged. Or if you want I can
fix it in the separate PR, but with your commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
