sohami commented on a change in pull request #1652: DRILL-7046: Support for
loading and parsing new RM config file
URL: https://github.com/apache/drill/pull/1652#discussion_r260028882
##########
File path:
common/src/main/java/org/apache/drill/common/config/CommonConstants.java
##########
@@ -17,21 +17,33 @@
*/
package org.apache.drill.common.config;
-public interface CommonConstants {
+public final class CommonConstants {
Review comment:
I feel like interfaces should be used to define a contract which any
implementation will provide. Whereas constant parameters can be treated as an
implementation details of a class. If we define constants in an interface then
these constants will be leaked to all the implementation which may or may not
be using it. Even though there were no method in this interface, it exposes the
risk of having one. For example I myself was considering this interface earlier
to provide methods defined in ConfigFileInfo. To avoid that in future I thought
of converting it into a final class with private constructor.
I have changed the name of class to `ConfigConstants`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
