sohami commented on a change in pull request #1652: DRILL-7046: Support for loading and parsing new RM config file URL: https://github.com/apache/drill/pull/1652#discussion_r260520367
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/resourcemgr/selectionpolicy/RandomQueueSelection.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.resourcemgr.selectionpolicy; + +import org.apache.drill.exec.ops.QueryContext; +import org.apache.drill.exec.resourcemgr.NodeResources; +import org.apache.drill.exec.resourcemgr.ResourcePool; +import org.apache.drill.exec.resourcemgr.exception.QueueSelectionException; + +import java.util.Collections; +import java.util.List; + +/** + * Randomly selects a queue from the list of all the provided queues. If no pools are provided then it throws + * {@link QueueSelectionException} + */ +public class RandomQueueSelection extends AbstractQueueSelectionPolicy { + private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(RandomQueueSelection.class); + + public RandomQueueSelection() { + super("random"); + } + + @Override + public ResourcePool selectQueue(List<ResourcePool> allPools, QueryContext queryContext, + NodeResources maxResourcePerNode) throws QueueSelectionException { + if (allPools.size() == 0) { + throw new QueueSelectionException("Input pool list is empty for random queue selection"); + } + Collections.shuffle(allPools); Review comment: This policy is just to select any random queue. What you are describing can be another selection policy like randomBestFit i.e. if there are multiple queues whose maxQueryMemoryPerNode is greater than equal to maxResourcesPerNode then select one at random and throw exception if there is no such queue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
