vdiravka commented on a change in pull request #1681: DRILL-7051: Upgrade jetty
URL: https://github.com/apache/drill/pull/1681#discussion_r263127462
##########
File path: pom.xml
##########
@@ -85,6 +85,7 @@
<reflections.version>0.9.10</reflections.version>
<avro.version>1.8.2</avro.version>
<metrics.version>4.0.2</metrics.version>
+ <jetty.version>9.4.15.v20190215</jetty.version>
Review comment:
In current PR I have added jetty-dependencies to the `dependencyManagement`
block only.
It was done in scope of DRILL-68.. I have added a
[comment](https://issues.apache.org/jira/browse/DRILL-6540?focusedCommentId=16606306&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16606306)
that it was necessary for the HBase unit tests. So it can't be excluded.
Also I checked `mvn dependency:tree -Dincludes=org.eclipse.jetty` without
`dependencyManagement` block and found different versions of Jetty
```
[INFO] org.apache.drill.contrib:drill-format-mapr:jar:1.16.0-SNAPSHOT
[INFO] +- com.mapr.fs:mapr-hbase:jar:6.1.0-mapr:compile
[INFO] | \- org.apache.hbase:hbase-server:jar:2.1.1:compile
[INFO] | +- org.apache.hbase:hbase-http:jar:2.1.1:compile
[INFO] | | +- org.eclipse.jetty:jetty-util:jar:9.3.19.v20170502:compile
[INFO] | | \-
org.eclipse.jetty:jetty-util-ajax:jar:9.3.19.v20170502:compile
[INFO] | \- org.eclipse.jetty:jetty-webapp:jar:9.3.19.v20170502:compile
[INFO] | \- org.eclipse.jetty:jetty-xml:jar:9.3.19.v20170502:compile
[INFO] \- org.apache.drill.exec:drill-java-exec:jar:1.16.0-SNAPSHOT:compile
[INFO] +- org.eclipse.jetty:jetty-server:jar:9.4.15.v20190215:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:9.4.15.v20190215:compile
[INFO] | \- org.eclipse.jetty:jetty-io:jar:9.4.15.v20190215:compile
[INFO] +- org.eclipse.jetty:jetty-servlet:jar:9.4.15.v20190215:compile
[INFO] | \- org.eclipse.jetty:jetty-security:jar:9.4.15.v20190215:compile
[INFO] +- org.eclipse.jetty:jetty-servlets:jar:9.4.15.v20190215:compile
[INFO] \-
org.glassfish.jersey.containers:jersey-container-jetty-servlet:jar:2.8:compile
[INFO] \-
org.glassfish.jersey.containers:jersey-container-jetty-http:jar:2.8:compile
[INFO] \-
org.eclipse.jetty:jetty-continuation:jar:9.1.1.v20140108:compile
[INFO]
------------------------------------------------------------------------
```
Therefore since Jetty dependencies are used not only in `java-exec` it is
nesessary to handle their versions in Drill root POM file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
