vdiravka commented on a change in pull request #1681: DRILL-7051: Upgrade jetty
URL: https://github.com/apache/drill/pull/1681#discussion_r268551237
##########
File path: pom.xml
##########
@@ -85,6 +85,7 @@
<reflections.version>0.9.10</reflections.version>
<avro.version>1.8.2</avro.version>
<metrics.version>4.0.2</metrics.version>
+ <jetty.version>9.4.15.v20190215</jetty.version>
Review comment:
Finally jetty 9.3 is chosen for Drill.
Jetty dependencies are used in `java-exec pom.xml`, but I've left versions
control in `dependencyManagement` block of root POM to avoid picking invalid
jetty version by maven, in case when some libs will have other version.
For instance we can't exclude jetty from `hadoop-common` and `hbase`
dependencies. But they have different jetty minor versions:
[9.3.24.v20180605](https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml#L38)
for Hadoop
[9.3.19.v20170502](https://github.com/apache/hbase/blob/rel/2.1.0/pom.xml#L1352)
for HBase 2.1 and
[9.3.25.v20180904](https://github.com/apache/hbase/blob/master/pom.xml#L1529)
for master HBase version.
I didn't find any API compatibility differences between these jetty minor
versions (only 9.4 has it).
Possibly in future we can consider shade Jetty version in Drill,
[DRILL-7135](https://issues.apache.org/jira/browse/DRILL-7135). Not sure that
is necessary for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
