sohami commented on issue #1650: DRILL-6707: Allow Merge-Join batch resizing to go smaller than current outgoing row count URL: https://github.com/apache/drill/pull/1650#issuecomment-472197996 @Ben-Zvi - Changes in step (3) and (4) are not required that will mess up the calculation of `RecordBatchMemoryManager` and it's resulting in lots of test failures as well. For lateral tests as discussed there is a separate change needed in lateral to call `getOutputRowCount()` in case when new output batch is allocated and `getCurrentOutgoingMaxRowCount` in cases when already allocated output batch is used to fill rows from new incoming. After that the failing test will pass. Also the `outputIndex` check in `allocateVectors` is there to handle a special case of left join. I have added comments to explain the scenario. With all above changes there were few `HashJoin Tests `which were failing because of a bug and I have addressed that too in my commit. Please see all set of changes here: https://github.com/Ben-Zvi/drill/pull/9 . You can add that commit in your PR. Currently I am running tests to see if there are any other issues which may need change in the respective operator.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
