arina-ielchiieva commented on a change in pull request #1692: DRILL-6562: 
Plugin Management improvements
URL: https://github.com/apache/drill/pull/1692#discussion_r265068000
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/storage/update.ftl
 ##########
 @@ -38,26 +38,59 @@
       </textarea>
     </div>
     <a class="btn btn-default" href="/storage">Back</a>
-    <button class="btn btn-default" type="submit" onclick="doUpdate();">
-      <#if model.exists()>Update<#else>Create</#if>
-    </button>
-    <#if model.exists()>
-      <#if model.enabled()>
-        <a id="enabled" class="btn btn-default">Disable</a>
-      <#else>
-        <a id="enabled" class="btn btn-primary">Enable</a>
-      </#if>
-      <a class="btn btn-default" 
href="/storage/${model.getName()}/export"">Export</a>
-      <a id="del" class="btn btn-danger" onclick="deleteFunction()">Delete</a>
+    <button class="btn btn-default" type="submit" 
onclick="doUpdate();">Update</button>
+    <#if model.enabled()>
+      <a id="enabled" class="btn btn-default">Disable</a>
+    <#else>
+      <a id="enabled" class="btn btn-primary">Enable</a>
     </#if>
+    <button type="button" class="btn btn-default export" 
name="${model.getName()}" data-toggle="modal"
+            data-target="#pluginsModal">
+      Export
+    </button>
+    <a id="del" class="btn btn-danger" onclick="deleteFunction()">Delete</a>
   </form>
   <br>
   <div id="message" class="hidden alert alert-info">
   </div>
-  <script>
-    var editor = ace.edit("editor");
-    var textarea = $('textarea[name="config"]');
 
+  <#-- Modal window-->
+  <div class="modal fade" id="pluginsModal" tabindex="-1" role="dialog" 
aria-labelledby="exportPlugin" aria-hidden="true">
+    <div class="modal-dialog modal-sm" role="document">
+      <!-- Modal content-->
+      <div class="modal-content">
+        <div class="modal-header">
+          <button type="button" class="close" data-dismiss="modal" 
aria-hidden="true">&times;</button>
+          <h4 class="modal-title" id="exportPlugin">Export Plugin config</h4>
+        </div>
+        <div class="modal-body">
+          <div id="format" style="display: inline-block; position: center;">
+            <label for="format">File type</label>
 
 Review comment:
   ```suggestion
               <label for="format">Format</label>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to