arina-ielchiieva commented on a change in pull request #1692: DRILL-6562: 
Plugin Management improvements
URL: https://github.com/apache/drill/pull/1692#discussion_r265067679
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/storage/update.ftl
 ##########
 @@ -107,15 +140,34 @@
           }, 200);
         }
       });
-    };
+    }
     function deleteFunction() {
-      var temp = confirm("Are you sure?");
-      if (temp == true) {
-        $.get("/storage/${model.getName()}/delete", function(data) {
+      if (confirm("Are you sure?")) {
+        $.get("/storage/${model.getName()}/delete", function() {
           window.location.href = "/storage";
         });
       }
-    };
+    }
+
+    // Modal window management
+    $('#pluginsModal').on('show.bs.modal', function (event) {
+      const button = $(event.relatedTarget) // Button that triggered the modal
+      let exportInstance = button.attr("name");
+      const modal = $(this);
+      modal.find('.modal-title').text('Export '+ exportInstance.toUpperCase() 
+' Plugin configs');
 
 Review comment:
   ```suggestion
         modal.find('.modal-title').text(exportInstance.toUpperCase() +' Plugin 
config');
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to