vdiravka commented on a change in pull request #1723: DRILL-7063: Seperate 
metadata cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r270744162
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
 ##########
 @@ -387,6 +389,14 @@ private static boolean allowBinaryMetadata(String 
drillVersion, ParquetReaderCon
           names.add(Arrays.asList(columnTypeMetadata.name));
         }
       }
+    } else if (parquetTableMetadata instanceof ParquetTableMetadata_v4) {
 
 Review comment:
   This logic is almost the same as for `ParquetTableMetadata_v3`.
   Can you change usage of `columnTypeInfo` field to getter everywhere?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to