vdiravka commented on a change in pull request #1723: DRILL-7063: Seperate
metadata cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r270776958
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/metadata/Metadata.java
##########
@@ -91,9 +95,14 @@
public class Metadata {
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(Metadata.class);
- public static final String[] OLD_METADATA_FILENAMES =
{".drill.parquet_metadata.v2"};
+ public static final String[] OLD_METADATA_FILENAMES =
{".drill.parquet_metadata", ".drill.parquet_metadata.v2"};
public static final String METADATA_FILENAME = ".drill.parquet_metadata";
public static final String METADATA_DIRECTORIES_FILENAME =
".drill.parquet_metadata_directories";
+ public static final String FILE_METADATA_FILENAME =
".drill.parquet_file_metadata.v4";
Review comment:
Looks like `METADATA_FILENAME` should be some sort of `OLD_METADATA_FILENAME`
but `FILE_METADATA_FILENAME` -> `METADATA_FILENAME`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
