vdiravka commented on a change in pull request #1706: DRILL-7115: Improve Hive
schema show tables performance
URL: https://github.com/apache/drill/pull/1706#discussion_r271164002
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaRecordGenerator.java
##########
@@ -266,8 +266,7 @@ private void scanSchema(String schemaPath, SchemaPlus
schema) {
*/
public void visitTables(String schemaPath, SchemaPlus schema) {
final AbstractSchema drillSchema = schema.unwrap(AbstractSchema.class);
- final List<String> tableNames = Lists.newArrayList(schema.getTableNames());
- for(Pair<String, ? extends Table> tableNameToTable :
drillSchema.getTablesByNames(tableNames)) {
+ for(Pair<String, ? extends Table> tableNameToTable :
drillSchema.getTablesByNames(schema.getTableNames())) {
Review comment:
```suggestion
for (Pair<String, ? extends Table> tableNameToTable :
drillSchema.getTablesByNames(schema.getTableNames())) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
