vdiravka commented on a change in pull request #1706: DRILL-7115: Improve Hive
schema show tables performance
URL: https://github.com/apache/drill/pull/1706#discussion_r271924190
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilter.java
##########
@@ -206,11 +203,11 @@ private Result evaluateHelperFunction(Map<String,
String> recordValues, Function
for(ExprNode arg : exprNode.args) {
Result exprResult = evaluateHelper(recordValues, arg);
- if (exprResult == Result.FALSE) {
- return exprResult;
- }
- if (exprResult == Result.INCONCLUSIVE) {
- result = Result.INCONCLUSIVE;
+ switch (exprResult) {
Review comment:
oh, sorry, I wonder how I missed it.
Looks like `switch`-`case` approach is more elegant here. Feel free to
return you previous version, if you want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
