amansinha100 commented on a change in pull request #1723: DRILL-7063: Seperate
metadata cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r272249873
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/BaseParquetMetadataProvider.java
##########
@@ -167,6 +172,7 @@ public TableMetadata getTableMetadata() {
columnsStatistics.put(partitionColumn, new
ColumnStatisticsImpl(stats,
ParquetTableMetadataUtils.getNaturalNullsFirstComparator()));
}
}
+ columnsStatistics = populateColumnStats(columnsStatistics);
Review comment:
Its confusing that even though previously we had called
`mergeColumnStatistics()`, or the `put()` in the else part, here there's a call
to `populateColumnStats()` which at first glance would seem redundant. If
these cannot be consolidated, please add some comments and a javadoc for
`populateColumnStats()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
