amansinha100 commented on a change in pull request #1723: DRILL-7063: Seperate
metadata cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r272259357
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetTableMetadataUtils.java
##########
@@ -282,7 +286,24 @@ public static PartitionMetadata
getPartitionMetadata(SchemaPath partitionColumn,
statistics.put(ColumnStatisticsKind.NULLS_COUNT.getName(), nulls);
columnsStatistics.put(colPath, new ColumnStatisticsImpl(statistics,
comparator));
}
+ columnsStatistics = populateColumnStats(columnsStatistics, tableMetadata);
+ return columnsStatistics;
+ }
+ private static Map<SchemaPath, ColumnStatistics>
populateColumnStats(Map<SchemaPath, ColumnStatistics> columnsStatistics,
MetadataBase.ParquetTableMetadataBase parquetTableMetadata) {
Review comment:
What's the difference between this method and a similar
`populateColumnStats` in `BaseParquetMetadataProvider` ? More than 1
'populate' methods creates code maintenance issues in the future.
Minor code style: line too long ?
Also add javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
