vvysotskyi commented on a change in pull request #1723: DRILL-7063: Seperate
metadata cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r272535994
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/BaseParquetMetadataProvider.java
##########
@@ -165,6 +165,7 @@ public TableMetadata getTableMetadata() {
TableStatisticsKind.ROW_COUNT.getName(), columnValueCount,
ColumnStatisticsKind.NULLS_COUNT.getName(),
getParquetGroupScanStatistics().getRowCount() - columnValueCount);
columnsStatistics.put(partitionColumn, new
ColumnStatisticsImpl(stats,
ParquetTableMetadataUtils.getNaturalNullsFirstComparator()));
+ columnsStatistics =
ParquetTableMetadataUtils.populateNonInterestingColumnsStats(columnsStatistics,
parquetTableMetadata);
Review comment:
Looks like `columnsStatistics` map will be reassigned every iteration of the
loop.
Could you please move this line outside the cycle and, perhaps instead of
reassigning use `putAll()` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
