vvysotskyi commented on a change in pull request #1723: DRILL-7063: Seperate
metadata cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r272538245
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetTableMetadataUtils.java
##########
@@ -282,7 +286,32 @@ public static PartitionMetadata
getPartitionMetadata(SchemaPath partitionColumn,
statistics.put(ColumnStatisticsKind.NULLS_COUNT.getName(), nulls);
columnsStatistics.put(colPath, new ColumnStatisticsImpl(statistics,
comparator));
}
+ columnsStatistics = populateNonInterestingColumnsStats(columnsStatistics,
tableMetadata);
+ return columnsStatistics;
+ }
+ /**
+ * Populates the non-interesting column's statistics
+ * @param columnsStatistics
+ * @param parquetTableMetadata
+ * @return returns new column statistics map
+ */
+ public static Map<SchemaPath, ColumnStatistics>
populateNonInterestingColumnsStats(
Review comment:
Could you please instead of passing `columnsStatistics` to this method, pass
list of `SchemaPath` which should be handled, and create a new map for results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
